Remove redundant build tags #1244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandear
force-pushed
the
chore-redundant-build-tags
branch
3 times, most recently
from
b9c66fe to
4547b5b
Compare
dhui
reviewed
Apr 17, 2025
Member
dhui
left a comment
dhui
left a comment
There was a problem hiding this comment.
@alexandear Thanks for the cleanup! Could you rebase your PR to fix the merge conflicts?
alexandear
force-pushed
the
chore-redundant-build-tags
branch
from
4547b5b to
34c2b4a
Compare
dhui
approved these changes
Apr 17, 2025
Member
dhui
left a comment
dhui
left a comment
There was a problem hiding this comment.
@alexandear Thanks for the cleanup!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes outdated in Go 1.22
// +buildcomments by running the command:Additionally, enables
revive.redundant-build-tagto detect redundant build tags in the future. This rule introduced by the newest golangci-lint, so I need to update it's version as well.From https://pkg.go.dev/cmd/go#hdr-Build_constraints: